fix(simulator): Reconcile simulator defaults when id+name are set#377
Merged
cameroncooke merged 2 commits intomainfrom Apr 29, 2026
Merged
fix(simulator): Reconcile simulator defaults when id+name are set#377cameroncooke merged 2 commits intomainfrom
cameroncooke merged 2 commits intomainfrom
Conversation
Refresh simulator defaults now validates simulatorName even when simulatorId is already set. When the resolved id differs, session defaults are patched in memory only so machine-specific UUID drift does not break simulator commands. Add focused tests for the both-set behavior (match, mismatch, and lookup failure) and document the fix in the unreleased changelog. Fixes #357 Co-Authored-By: OpenAI Codex <noreply@openai.com>
commit: |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2209c90. Configure here.
Resolve simulator IDs from simulatorName in a single branch so name-only defaults do not fall through into the both-set reconciliation path. Keep simulatorName as the source of truth when present and only patch simulatorId when the resolved value differs. Add regression coverage for the name-only refresh path to ensure it performs one resolver call. Refs #357 Co-Authored-By: OpenAI Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reconcile simulator defaults by simulator name even when both
simulatorIdandsimulatorNameare present.Today
refreshSimulatorDefaultsonly reconciles in one-sided cases (id-only or name-only), so a stale committed simulator UUID can survive unchanged when both keys are set. This change keeps the existing simple refresh flow and adds one branch for the both-set case: resolvesimulatorName -> simulatorId, and patch in-memory defaults only when the resolved id differs.I considered adding broader fallback behavior, but that would be over-scoped for this bug and against the canonical approach in #357. This PR intentionally stays localized to the refresh utility and focused tests.
Fixes #357